|
| From: | Bruno Haible |
| Subject: | Re: [PATCH 1/5] posix: Sync regex code with gnulib |
| Date: | Tue, 19 Jan 2021 16:43:10 +0100 |
| User-agent: | KMail/5.1.3 (Linux/4.4.0-197-generic; KDE/5.18.0; x86_64; ; ) |
Adhemerval Zanella wrote: > -# if (__GNUC__ >= 7) || (__clang_major__ >= 10) > +# if (__GNUC__ >= 7) || (defined __clang_major__ &&__clang_major__ >= 10) I would write it as: +# if (__GNUC__ >= 7) || (defined __clang__ && __clang_major__ >= 10) because 'defined __clang__' is the widely known way to test for a clang (or derivate) compiler. Bruno
| [Prev in Thread] | Current Thread | [Next in Thread] |