[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix NFSv4 acl detection on F39
|
From: |
Bruno Haible |
|
Subject: |
Re: [PATCH] fix NFSv4 acl detection on F39 |
|
Date: |
Mon, 1 May 2023 22:31:00 +0200 (CEST) |
Hi Ondrej,
I leave the semantic evaluation of the patch to Paul.
But I would nevertheless point out:
- Freeing an object sometimes in the caller and sometimes in the
callee (function have_xattr) is an invitation for memory bugs
to appear in future changes. It would be better to keep the
ownership of this object in the caller.
- Why is have_xattr not a 'static' function?
- GNU coding style please, e.g. regarding the placement of braces.
Thanks.
Bruno
- [PATCH] fix NFSv4 acl detection on F39, Ondrej Valousek, 2023/05/01
- Re: [PATCH] fix NFSv4 acl detection on F39,
Bruno Haible <=
- Re: [PATCH] fix NFSv4 acl detection on F39, Paul Eggert, 2023/05/01
- Re: [PATCH] fix NFSv4 acl detection on F39, Paul Eggert, 2023/05/02
- Re: [PATCH] fix NFSv4 acl detection on F39, Ondrej Valousek, 2023/05/03
- Re: [PATCH] fix NFSv4 acl detection on F39, Paul Eggert, 2023/05/03
- RE: [PATCH] fix NFSv4 acl detection on F39, Ondrej Valousek, 2023/05/04
- Re: [PATCH] fix NFSv4 acl detection on F39, Bruno Haible, 2023/05/04
- Re: [PATCH] fix NFSv4 acl detection on F39, Paul Eggert, 2023/05/12
- Re: [PATCH] fix NFSv4 acl detection on F39, Paul Eggert, 2023/05/12
- RE: [PATCH] fix NFSv4 acl detection on F39, Ondrej Valousek, 2023/05/15
- Re: [PATCH] fix NFSv4 acl detection on F39, Paul Eggert, 2023/05/15