Re: error: Support the compiler's control flow analysis better (was: copy-file: Silence gcc warnings)

[Paul Eggert]

On 5/30/23 15:06, Bruno Haible wrote:

> In terms of functions calls, I don't think it makes a difference,
> whether exit() gets called from within the error() invocation [1] or
> after the error() invocation.

It makes the calling code a bit smaller, e.g., it avoids GCC having to 
generate code to save and restore registers in the caller, along with 
issuing two calls instead of one. Admittedly not a huge deal.

I also vaguely think that perhaps GCC will find the resulting code 
easier to analyze. Although this is just a guess, GCC is kinda buggy in 
this area and I hope the smaller code avoid bugs.


> > +     __gl_error_call (rpl_error, status, __VA_ARGS)
>
> What is __VA_ARGS ? Did you mean __VA_ARGS__ ?

Yes I did. Thanks for catching that typo. I installed a fix.