Re: Test for pthread_rwlock_init() always passes, regardless

[Sevan Janiyan]

On 09/11/2023 02:36, Bruno Haible wrote:
> The lack of PTHREAD_RWLOCK_INITIALIZER is the only problem we have identified
> so far. But it is severe enough that gnulib better overrides all
> pthread_rwlock_* functions. Done through this patch:

Thanks for the patch, configure detects things on Tiger correctly and 
test-pthread-rwlock now passes.

I've not followed the project for a length of time and unfamiliar with 
the coding style but I was wondering why did you opt to add a new case 
specifically for Darwin, where the generic catchall could be to utilise 
pthread_rwlock_init by calling it with PTHREAD_RWLOCK_INITIALIZER, and 
handle the case for Android by itself? You would have a broader coverage 
by default and avoid having to add lots of individual cases as you hit them.


Sevan