bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] gnulib-tool.py: Fix function call on incorrect object.


From: Collin Funk
Subject: [PATCH] gnulib-tool.py: Fix function call on incorrect object.
Date: Sun, 18 Feb 2024 17:24:46 -0800
User-agent: Mozilla Thunderbird

I was looking around the gnulib code and decided to try out the Python
gnulib-tool. It looks like it hasn't been touched in a while so I
wanted to see what state it was in. Coreutils fails because
--automake-subdir is not supported (already documented in
gnulib-tool.py.TODO). GNU m4 gave the following error:

bootstrap: running: gnulib/gnulib-tool.py --no-changelog --no-libtool --symlink 
--update
Traceback (most recent call last):
  File "/home/collin/.local/src/m4/gnulib/gnulib-tool.py", line 1171, in 
<module>
    main()
  File "/home/collin/.local/src/m4/gnulib/gnulib-tool.py", line 886, in main
    importer = classes.GLImport(config, mode)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/collin/.local/src/m4/gnulib/pygnulib/GLImport.py", line 243, in 
__init__
    if self.checkInclTestCategory(TESTS['tests']) and self.config['conddeps']:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'GLImport' object has no attribute 'checkInclTestCategory'

I assume this was just caused by a small coding typo (if that is a
thing). This patch should fix it. The M4 build still fails because of
the !@NMD@ which is documented in TODO along with a few other errors
with the generated Makefile.

What is the status of the Python gnulib tool? I'm not sure how far
behind it is compared to the shell script but it seems like it would
be much faster. I would say more maintainable but I might just be bad
at writing shell scripts. :)

Collin

Attachment: 0001-gnulib-tool.py-Fix-function-call-on-incorrect-object.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]