Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

[Bruno Haible]

Hello Collin,

> -    for m in $modules; do echo $m; done | LC_ALL=C sort -u > "$tmp"/modules
> +    for m in $referenceable_modules; do echo $m; done | LC_ALL=C sort -u > 
> "$tmp"/modules
> 
> Which I didn't understand until seeing this line [1]:
> 
> deps=`for m in $deps; do echo $m; done | LC_ALL=C sort -u | LC_ALL=C join - 
> "$tmp"/modules`
> 
> This just means that join takes stdin as its first file which is the
> piped output of sort. Then the second file is the sorted
> referenceable_modules stored in "$tmp"/modules right?

Correct.

> If I am interpreting that correctly then the lines I used would be
> correct I think:
> 
> depmodules = sorted(set(depmodules).intersection(referenceable_modules))

Yes, correct.

> +     Follow gnulib-tool change
> +     2017-12-28  Bruno Haible  <bruno@clisp.org>
> +     gnulib-tool: Make --conditional-dependencies work better.
> -commit 589e96475f8f2d21a83405ab0672ce95091b80e5

In the original commit, I removed the error message
"option --conditional-dependencies is not supported with --with-tests"
only at one place (the command-line option checks), but left it in func_import.
You are removing it in both places (mode == 'import' as well as mode != 
'import).

The rest of the patch looks fine.

Bruno