bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 41.


From: Collin Funk
Subject: Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 41.
Date: Tue, 5 Mar 2024 16:39:26 -0800
User-agent: Mozilla Thunderbird

Hi Bruno,

On 3/5/24 3:08 PM, Bruno Haible wrote:
> Oops, these comments of mine apply to part 41, not part 40!

No worries. I should have numbered the patches 0001, 0002, 0003 to
make your life easier. :)

>> Thanks, but there's a difference here:
>> In gnulib-tool the condition was
>>
>>         if test "${var}" = SUBDIRS && test -n "$dotfirst"; then
>>
>> whereas in your patch, in pygnulib/GLEmiter.py lines 804 and 1108, I see
>>
>>                     if dictionary['dotfirst']:
>>
>> Where has the condition
>>
>>            test "${var}" = SUBDIRS
>>
>> gone?

Good catch. My excuse will be that I was busy making sure I didn't mix
up 'var' and 'val'...

I've attached a patch that uses the condition:

     if dictionary['var'] == 'SUBDIRS' and dictionary['dotfirst']:

which should match the original commit.

Collin

Attachment: 0001-gnulib-tool.py-Follow-gnulib-tool-changes-part-41.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]