Re: [PATCH] gnulib-tool.py: Fix write failure due to bad sourcebase.

[Bruno Haible]

Hi Collin,

> This patch should fix gnulib-tool.py when running
> 'gnulib-tool.py --add-import' in OATH Toolkit.
> 
> It appears that gnulib-tool.py was not picking up the m4 directories
> correctly. This means that when the GLImport object was created it
> could not find the gnulib-cache.m4 file containing the sourcebase.

This patch looks better than the previous one, that added a
setSourceBase('lib') invocation. Applied. Thanks!

> This appeared as a failure to write since gnulib-tool.py was trying to
> write to '$sourcebase/dummy.c' where $sourcebase was an empty string.
> 
> The other change prevents calling 'obj.split()' where obj is not a
> string:
> 
>          sequence = [ True if value == 'true' else value
>                       for value in sequence ]
>          sequence = [ value.strip()
> +                     if type(value) is str else value
>                       for value in sequence ]

Is converting 'true' to True a good thing to do here anyway?
Which invocations of the 'cleaner' function need this?

Bruno