bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 57.


From: Collin Funk
Subject: Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 57.
Date: Thu, 14 Mar 2024 19:44:54 -0700
User-agent: Mozilla Thunderbird

Hi Bruno,

On 3/14/24 7:23 PM, Bruno Haible wrote:
> Thanks! Applied, with a tiny comment change: I removed the dollars from
>   # Remove $handledmodules from $inmodules.

Oops, in the commit before I added some comments directly from
gnulib-tool to main.py as well. Feel free to change them if you'd like
or I can do it when I change code there again.

At first I found the comments helpful for finding my way around. Since
naming conventions are different (e.g. GLModule.getApplicability vs
func_get_applicability) it was easier to search for comments.

I can find my way around well enough now, and since the goal is to
*eventually* switch to the Python version, referring to shell things
probably isn't too helpful, and may be confusing.

Collin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]