gnulib-tool.py: Fix an error in --create-testdir

[Bruno Haible]

This test error

$ GNULIB_TOOL_IMPL=py ./test-create-testdir-1.sh 
configure.ac:8: installing 'build-aux/compile'
configure.ac:4: installing 'build-aux/install-sh'
configure.ac:4: installing 'build-aux/missing'
gllib/Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
Traceback (most recent call last):
  File "/media/develdata/devel/GNULIB/gnulib-git/pygnulib/main.py", line 1341, 
in <module>
    main()
  File "/media/develdata/devel/GNULIB/gnulib-git/pygnulib/main.py", line 1035, 
in main
    testdir.execute()
  File "/media/develdata/devel/GNULIB/gnulib-git/pygnulib/GLTestDir.py", line 
877, in execute
    os.chdir(self.testdir)
FileNotFoundError: [Errno 2] No such file or directory: 'tmp1119113-result'
FAIL: gnulib-tool exited with code 1.

is fixed by the following patch:


2024-03-22  Bruno Haible  <bruno@clisp.org>

        gnulib-tool.py: Fix an error in --create-testdir.
        * pygnulib/GLTestDir.py (GLTestDir.execute): Fix chdir calls at the end.

diff --git a/pygnulib/GLTestDir.py b/pygnulib/GLTestDir.py
index c450f74099..f85a5f6dbb 100644
--- a/pygnulib/GLTestDir.py
+++ b/pygnulib/GLTestDir.py
@@ -835,8 +835,8 @@ class GLTestDir(object):
                                                 for file in tests_built_sources
                                                 if file not in cleaned_files]
 
+        os.chdir(self.testdir)
         if distributed_built_sources or tests_distributed_built_sources:
-            os.chdir(self.testdir)
             sp.call('./configure')
             if distributed_built_sources:
                 os.chdir(sourcebase)
@@ -874,7 +874,6 @@ class GLTestDir(object):
                     'LIBTOOLIZE=%s' % UTILS['libtoolize'],
                     'distclean']
             sp.call(args)
-        os.chdir(self.testdir)
         if isfile(joinpath('build-aux', 'test-driver')):
             _patch_test_driver()
         os.chdir(DIRS['cwd'])