Re: [PATCH] gnulib-tool.py: Don't use --[no]-vc-files unless explicitly given.

[Collin Funk]

On 3/23/24 4:49 AM, Bruno Haible wrote:
> If the variable has 3 possible values (None, False, True), then writing
> 'if value == True:' is the simpler way. Why would one use a conversion to
> bool, i.e. 3-values to 2-values conversion? It would only make things
> more complicated.

Yes, I agree now. I think that I saw True / False and figured it
should just be treated as a bool. However, the way GLConfig is set up,
vc_files along with many other variables can also be None. Therefore,
that assumption is bad. I will be more careful about that in the
future...

Type hints in the future will help:

# This
vc_files: bool | None
# Not this
vc_files: bool

I've attached an updated patch.

Collin

0001-gnulib-tool.py-Don-t-print-Python-bools-in-gnulib-ca.patch
Description: Text Data