Re: gnulib-tool.py: Don't discard the 'dummy' module.

[Bruno Haible]

Collin Funk wrote:
> In a few of the import tests gnulib-tool.py doesn't add the 'dummy'
> module even though gnulib-tool.sh does.
> 
> This is because the 'dummy' module was added after GLImport saved the
> modules in the GLModuleTable:
> 
>         # Transmit base_modules, final_modules, main_modules and 
> tests_modules.
>         self.moduletable.setBaseModules(base_modules)
>         self.moduletable.setFinalModules(final_modules)
>         self.moduletable.setMainModules(main_modules)
>         self.moduletable.setTestsModules(tests_modules)
> 
> After reordering these, the output is still incorrect. gnulib-tool.py
> places the 'dummy' module at the top of the Makefiles, but
> gnulib-tool.sh places them at the bottom.
> 
> Changing the moduletable functions to remove the sorting here seems to
> fix the issue:

Thanks! Patch applied.

> -        self.tests_modules = sorted(set(modules))
> +        self.tests_modules = modules

I see. This is similar to the initial code for the GLMakefileTable, which
cloned the table row in the getter. Here it sorted the lists in the setter.
Feels like a "safety first" attitude that was slightly exaggerated.

Bruno