Re: [PATCH] m4/printf.m4: include <unistd.h> when useful

[Arsen Arsenović]

Hi Bruno,

Bruno Haible <bruno@clisp.org> writes:

> Hi Arsen,
>
> Thanks for the report.
>
>> https://bugs.gentoo.org/935126
>
> The essential lines in the build.log attachment there seem to be:
>
>  * QA Notice: Found the following implicit function declarations in configure 
> logs:
>  *   /var/tmp/portage/dev-util/poke-4.1/work/poke-4.1/config.log:6859 - _exit
>  *   /var/tmp/portage/dev-util/poke-4.1/work/poke-4.1/config.log:11911 - _exit
>  * Check that no features were accidentally disabled.
>  * See https://wiki.gentoo.org/wiki/Modern_C_porting.
>
> _exit() needs <unistd.h> on POSIX-like platforms but <stdlib.h> on
> native Windows.

Indeed.

>> * m4/printf.m4 (gl_SNPRINTF_DIRECTIVE_N): Add missing include for
>> unistd.h.
>> (gl_PRINTF_DIRECTIVE_N): Likewise.
>
> I can't take this patch, because <unistd.h> does not exist on MSVC.

Oh!  I did not know that.

> I also considered using _Exit instead of _exit, since it is always
> declared in <stdlib.h>. But it would produce portability problems on
> some older platforms (Android, HP-UX, Minix).
>
> So, I'm fixing it like this:
>

Ah!  Even better!  Thank you very much :-)

Have a lovely day!
-- 
Arsen Arsenović

signature.asc
Description: PGP signature