bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maint.mk: RELEASE leaking into VERSION


From: Bruno Haible
Subject: Re: maint.mk: RELEASE leaking into VERSION
Date: Wed, 03 Jul 2024 20:30:35 +0200

Hi Simon,

> Can someone think of a simple but backwards compatible fix here?

I don't think it needs to be backwards-compatible. The maintainers can
afford to change their habits from

  make release RELEASE='1.2 stable'

to

  make release VERSION=1.2 RELEASE_TYPE=stable

> The reason all this happens is this code in top/maint.mk:
> 
> # If RELEASE_TYPE is undefined, but RELEASE is, use its second word.
> # But overwrite VERSION.
> ifdef RELEASE
>   VERSION := $(word 1, $(RELEASE))
>   RELEASE_TYPE ?= $(word 2, $(RELEASE))
> endif

I would remove these few lines, and update top/README-release accordingly.

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]