Re: [PATCH] timevar: add missing timevar.def

[Bruno Haible]

Hi Paul,

> diff --git a/modules/timevar b/modules/timevar
> index ef86fedb29..a460a08de8 100644
> --- a/modules/timevar
> +++ b/modules/timevar
> @@ -4,6 +4,7 @@ A simple self-profiling module based on timers.
>  Files:
>  lib/timevar.h
>  lib/timevar.c
> +lib/timevar.def
>  
>  Depends-on:
>  c99

I don't think this is good. The documentation
<https://www.gnu.org/software/gnulib/manual/html_node/Profiling-of-program-phases.html>
explains that this file is only a stub. The user is expected to
modify it. But modifying it is much harder (requires a --local-dir
option and a .diff file) if lib/timevar.def is part of the module.

gnulib-tool excludes the 'timevar' module by default from the testdirs
for this reason. See pygnulib/GLTestDir.py lines 149..159.

What was the immediate problem that you had with this module?

Bruno