bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] libgmp-mpq: New module.


From: Marc Nieper-Wißkirchen
Subject: Re: [PATCH 1/2] libgmp-mpq: New module.
Date: Thu, 29 Aug 2024 13:04:04 +0200



Am Do., 29. Aug. 2024 um 11:31 Uhr schrieb Bruno Haible <bruno@clisp.org>:
Hi Marc,

this looks good, except for two small things:

1) In the ChangeLog entry

> +     * lib/mini-mpq.c: New upstream source file.
> +     * lib/mini-mpq.h: New upstream source file.

I would like to see more precision about where "upstream" is.
Ideally, the URL that can be downloaded with 'wget'.

Fixed in pushed commit.
 

2) In the module description

> diff --git a/modules/libgmp-mpq b/modules/libgmp-mpq
> new file mode 100644
> index 0000000000..ac61b01bc2
> --- /dev/null
> +++ b/modules/libgmp-mpq
> @@ -0,0 +1,33 @@
> +Description:
> +GNU Multiple Precision Arithmetic library (mpq_* part),
> +or its mini-gmp substitute

The last line should be "or its mini-mpq substitute", right?

It depends on the meaning of "mini-gmp".  I followed your suggestion and fixed it in the pushed commit.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]