[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] wait-process: Use waitpid() from LIBCx on OS/2 kLIBC
|
From: |
KO Myung-Hun |
|
Subject: |
Re: [PATCH v2 1/2] wait-process: Use waitpid() from LIBCx on OS/2 kLIBC if possible |
|
Date: |
Fri, 20 Sep 2024 10:23:31 +0900 |
|
User-agent: |
Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 |
Hi/2.
Bruno Haible wrote:
> KO Myung-Hun wrote:
>> LIBCx is the kLIBC extension library which provides some enhanced
>> features to OS/2 kLIBC.
>>
>> It provides its own waitpid() to support its spawn2(). Use it if
>> possible.
>>
>> * lib/wait-process.c (klibc_waitpid) [kLIBC]: New function.
>> (waitpid) [kLIBC]: Define it to klibc_waitpid.
>
> The code looks good, but lacks comments. In the ChangeLog or git commit
> entry, please state *what* has changed, not *why* or *how* the code works.
> The *why* and *how* belong in comments.
>
How about this?
--
KO Myung-Hun
Korean OS/2 User Community : https://www.os2.kr/
v3-0001-wait-process-Use-waitpid-of-LIBCx-on-OS-2-kLIBC-i.patch
Description: Source code patch
[PATCH v2 2/2] spawn-pipe: Support a directory argument of create_pipe() on OS/2 kLIBC, KO Myung-Hun, 2024/09/19