Re: [PATCH] crc: Add PCLMUL implementation

[Simon Josefsson]

Thanks for continuing work on this!  I'd like to focus on a meta issue
first.  I'd prefer of the crc PCLMUL feature is "opt-in" from a package
maintainer point of view.  Do you see any problem with that?  What I'm
after is that people who import the 'crc' module now don't automatically
get the CRC PCLMUL implementation without also having to pull in a
crc-pclmul module.  Some packages will care about performance (gzip,
coreutils maybe?) but some will regard code size, complexity and risks
of bugs to be more important to optimize for.  Is there some way to
rework things for this?  It is okay to add stuff to crc.c, but could be
hidden by #ifdef's by some symbol #define'd by the new module.

Sam Russell <sam.h.russell@gmail.com> writes:

> diff --git a/modules/crc b/modules/crc
> index c8dc462a27..16743980e8 100644
> --- a/modules/crc
> +++ b/modules/crc
> @@ -11,9 +11,11 @@ m4/build-cc.m4
>  Depends-on:
>  stdint
>  endian
> +crc-x86_64 [GL_CRC_PCLMUL = 1]
>  
>  configure.ac:
>  AC_REQUIRE([gl_CRC_SLICE_BY_8])
> +AC_REQUIRE([gl_CRC_PCLMUL])
>  gl_BUILD_CC
>  AC_PROG_MKDIR_P

So this would be removed.

> +Maintainer:
> +Simon Josefsson

Add yourself as maintainer of the new module please :)

/Simon

signature.asc
Description: PGP signature