bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

iconv_open: doesn't handle NetBSD bmake


From: Simon Josefsson
Subject: iconv_open: doesn't handle NetBSD bmake
Date: Sat, 28 Dec 2024 21:52:17 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hi.  I tried building libidn using 'bmake' from Debian which labels
itself as NetBSD make and got this error message:

bmake: don't know how to make iconv_open-aix.h. Stop

Looking at modules/iconv_open it has these rules:

$(srcdir)/iconv_open-aix.h: $(srcdir)/iconv_open-aix.gperf
        $(V_GPERF)$(GPERF) -m 10 $(srcdir)/iconv_open-aix.gperf > 
$(srcdir)/iconv_open-aix.h-t1 \
        && sed -e 's|\([ "]\)[^ "]*/iconv_open-aix\.gperf\([ 
"]\)|\1iconv_open-aix.gperf\2|' \
               < $(srcdir)/iconv_open-aix.h-t1 > $(srcdir)/iconv_open-aix.h-t2 \
        && rm -f $(srcdir)/iconv_open-aix.h-t1 \
        && mv $(srcdir)/iconv_open-aix.h-t2 $(srcdir)/iconv_open-aix.h

It seems this make implementation barfs at
'$(srcdir)/iconv_open-aix.h:', even changing it into
'./iconv_open-aix.h:' works.

I naively suggest the patch below (which makes bmake happy), but I may
be missing something from how this is intended to work.  Ideas?

/Simon

diff --git a/modules/iconv_open b/modules/iconv_open
index 4993a07044..e08a9dba50 100644
--- a/modules/iconv_open
+++ b/modules/iconv_open
@@ -38,37 +38,37 @@ if GL_COND_OBJ_ICONV
 lib_SOURCES += iconv.c iconv_close.c
 endif
 
-$(srcdir)/iconv_open-aix.h: $(srcdir)/iconv_open-aix.gperf
+iconv_open-aix.h: $(srcdir)/iconv_open-aix.gperf
        $(V_GPERF)$(GPERF) -m 10 $(srcdir)/iconv_open-aix.gperf > 
$(srcdir)/iconv_open-aix.h-t1 \
        && sed -e 's|\([ "]\)[^ "]*/iconv_open-aix\.gperf\([ 
"]\)|\1iconv_open-aix.gperf\2|' \
               < $(srcdir)/iconv_open-aix.h-t1 > $(srcdir)/iconv_open-aix.h-t2 \
        && rm -f $(srcdir)/iconv_open-aix.h-t1 \
        && mv $(srcdir)/iconv_open-aix.h-t2 $(srcdir)/iconv_open-aix.h
-$(srcdir)/iconv_open-hpux.h: $(srcdir)/iconv_open-hpux.gperf
+iconv_open-hpux.h: $(srcdir)/iconv_open-hpux.gperf
        $(V_GPERF)$(GPERF) -m 10 $(srcdir)/iconv_open-hpux.gperf > 
$(srcdir)/iconv_open-hpux.h-t1 \
        && sed -e 's|\([ "]\)[^ "]*/iconv_open-hpux\.gperf\([ 
"]\)|\1iconv_open-hpux.gperf\2|' \
               < $(srcdir)/iconv_open-hpux.h-t1 > 
$(srcdir)/iconv_open-hpux.h-t2 \
        && rm -f $(srcdir)/iconv_open-hpux.h-t1 \
        && mv $(srcdir)/iconv_open-hpux.h-t2 $(srcdir)/iconv_open-hpux.h
-$(srcdir)/iconv_open-irix.h: $(srcdir)/iconv_open-irix.gperf
+iconv_open-irix.h: $(srcdir)/iconv_open-irix.gperf
        $(V_GPERF)$(GPERF) -m 10 $(srcdir)/iconv_open-irix.gperf > 
$(srcdir)/iconv_open-irix.h-t1 \
        && sed -e 's|\([ "]\)[^ "]*/iconv_open-irix\.gperf\([ 
"]\)|\1iconv_open-irix.gperf\2|' \
               < $(srcdir)/iconv_open-irix.h-t1 > 
$(srcdir)/iconv_open-irix.h-t2 \
        && rm -f $(srcdir)/iconv_open-irix.h-t1 \
        && mv $(srcdir)/iconv_open-irix.h-t2 $(srcdir)/iconv_open-irix.h
-$(srcdir)/iconv_open-osf.h: $(srcdir)/iconv_open-osf.gperf
+iconv_open-osf.h: $(srcdir)/iconv_open-osf.gperf
        $(V_GPERF)$(GPERF) -m 10 $(srcdir)/iconv_open-osf.gperf > 
$(srcdir)/iconv_open-osf.h-t1 \
        && sed -e 's|\([ "]\)[^ "]*/iconv_open-osf\.gperf\([ 
"]\)|\1iconv_open-osf.gperf\2|' \
               < $(srcdir)/iconv_open-osf.h-t1 > $(srcdir)/iconv_open-osf.h-t2 \
        && rm -f $(srcdir)/iconv_open-osf.h-t1 \
        && mv $(srcdir)/iconv_open-osf.h-t2 $(srcdir)/iconv_open-osf.h
-$(srcdir)/iconv_open-solaris.h: $(srcdir)/iconv_open-solaris.gperf
+iconv_open-solaris.h: $(srcdir)/iconv_open-solaris.gperf
        $(V_GPERF)$(GPERF) -m 10 $(srcdir)/iconv_open-solaris.gperf > 
$(srcdir)/iconv_open-solaris.h-t1 \
        && sed -e 's|\([ "]\)[^ "]*/iconv_open-solaris\.gperf\([ 
"]\)|\1iconv_open-solaris.gperf\2|' \
               < $(srcdir)/iconv_open-solaris.h-t1 > 
$(srcdir)/iconv_open-solaris.h-t2 \
        && rm -f $(srcdir)/iconv_open-solaris.h-t1 \
        && mv $(srcdir)/iconv_open-solaris.h-t2 $(srcdir)/iconv_open-solaris.h
-$(srcdir)/iconv_open-zos.h: $(srcdir)/iconv_open-zos.gperf
+iconv_open-zos.h: $(srcdir)/iconv_open-zos.gperf
        $(V_GPERF)$(GPERF) -m 10 $(srcdir)/iconv_open-zos.gperf > 
$(srcdir)/iconv_open-zos.h-t1 \
        && sed -e 's|\([ "]\)[^ "]*/iconv_open-zos\.gperf\([ 
"]\)|\1iconv_open-zos.gperf\2|' \
               < $(srcdir)/iconv_open-zos.h-t1 > $(srcdir)/iconv_open-zos.h-t2 \

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]