[Bug-gnupod] wrong bitrate in gnupod_convert_RIFF.pl

[Benoît Knecht]

Hello,

I was testing the video conversion feature (which is great, I must say),
but I noticed the videos were really low quality. I think this is
because the bitrate given to ffmpeg is supposed to be in bits/s, so
gnupod_convert_RIFF.pl tries to encode at 600 bits/s. I guess it was
meant to be 600 kbits/s, so here's the patch.

On a completely different subject, is album cover-art supported in any
way by gnupod? I couldn't find documentation about that.

Thanks.

--- gnupod_convert_RIFF.pl      2007-01-16 20:56:16.000000000 +0100
+++ gnupod_convert_RIFF-bitrate.pl      2007-01-16 21:13:27.000000000 +0100
@@ -42,7 +42,7 @@
 }
 elsif($gimme eq "GET_VIDEO") {
        my $tmpout = GNUpod::FooBar::get_u_path("/tmp/gnupod_video", "mp4");
-       my $x = system("ffmpeg", "-i", $file, "-b", 600, "-r", "29.97", "-s", 
"320x240",
+       my $x = system("ffmpeg", "-i", $file, "-b", 600000, "-r", "29.97", 
"-s", "320x240",
                       "-vcodec", "mpeg4", "-ab", 128, "-acodec", "aac", 
$tmpout);
        print "PATH:$tmpout\n";
 }

signature.asc
Description: OpenPGP digital signature