Re: Various retain/release bugs

[Nicola Pero]

Hi Alexander, 

thanks for the patches

> > 3.
> > NSMenu retains its NSMenuView; NSMenuView retains its NSMenu; NSMenuView
> > retains its NSMenuItemCell:s and they retain the NSMenuView, etc. Either
> > I'm missing something about how this is supposed to work or something is
> > really messed up here.

Yes - this is certainly wrong ... need to investigate this carefully ...
now I'm tired so I better start with the easy ones :-) rather than getting
it wrong - so be patient


> When that was fixed, I had to patch a bug in [NSApplication -dealloc].
> It was using TEST_RELEASE to free the menus, but releasing _windows_menu
> caused the menu's window to be closed and NSApplication was trying to
> update the windows menu using the (now invalid) _windows_menu object. I
> changed the TEST_RELEASE:s to DESTROY:s and it worked. I've attached a
> patch.

Thanks - good point - applied


> Now that my windows are being dealloc:d properly, they keep forgetting
> their frames. Turns out [NSWindow -dealloc] is calling [self
> setFrameAutosaveName: nil] which makes setFrameAutosaveName remove the
> defaults key for the old name. I've attached a patch that makes dealloc
> remove the entry from _autosaveNames manually.

Thanks - nice spot - applied