Re: PSclip

[Alexander Malmberg]

> One thing puzzles me though - how come -Wall didnt throw  this up as a warning
> in the compile as surely it should generate a "may be used before
> cwbeing initialised" type thing ?

Turns out it's not using -Wall at all (if you don't have debug=yes, but
IIRC gcc doesn't do all the flow analysis then). I tried recompiling all
of xgps with -Wall, and there are a lot of warnings.

Some of these seem serious. I'm no expert on sequence points and all
that, but I highly doubt that this code's behavior is well-defined:

pixel = (rtable[*ptr++] + gtable[*ptr++]
        + btable[*ptr++] + base_pixel) & 0xffffffff;

gcc warns about a couple of these in convert.c and draw.c.

> -bat.

- Alexander Malmberg