Re: grep-2.5.4 Test Release

[Mike Frysinger]

On Monday 19 November 2007, Tony Abou-Assaleh wrote:
> I'd appreciate any feedback: Did I miss or mess something?

i see warnings about __restrict_arr being redefined in lib/posix/regex.h ... 
do you need to sync up latest regex code from gnulib ?

src/search.c:check_multibyte_string() calls wcrtomb() on a const string but 
wcrtomb() in most cases will be modifying the first argument (which is the 
const string)

> 2) Remove known failing cases from the release

can you iterate which those are ?  i see 2 failing tests: foad1.sh and 
yesno.sh ... seems like the foad1.sh tests show a pretty "bad" problem in 
grep that should get fixed rather than ignored ... or is my understanding of 
what is being tested incorrect ?  seems like failing "-o -i" is 
pretty "bad" ... especially as it's a regression from grep-2.5.1 ...

> Any suggestions on best way to keep CVS and release test cases partially
> out-of-sync? Some idea:
>
> * Apply a patch during 'make dist' that disables some tests
> * Factor out offending cases into separate files that are excluded from
> dist
> * Make the test files messy by adding switches to disable some test cases

in configure.ac, use "test -d CVS" and if the CVS dir does not exist, disable 
known failing tests

> Any preferences? There has been a lot of talk about writing a new uniform
> and clean test suite. But until someone does it we'll patch what we have.

rather than rewriting yet another testsuite by hand, have you seen autotest ?  
it's an attempt by the autotools guys for streamlining test integration for 
autotool-based projects
-mike

signature.asc
Description: This is a digitally signed message part.