|
| From: | Paolo Bonzini |
| Subject: | Re: [PATCH 5/6] fix cross-line matching in PCRE backend |
| Date: | Sat, 06 Mar 2010 10:03:12 +0100 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1 |
On 03/06/2010 09:56 AM, Jim Meyering wrote:
Won't this induce a large performance penalty for a buffer with no matches but with many lines?
It shouldn't be too large, at least until PCRE uses a normal per-character scan to find possible matches (instead of something like Boyer-Moore). That has the same complexity as memchr but a higher constant in front of it.
Anyway yes, it's a matter of correctness so... Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |