Re: [PATCH 5/5] Small refactoring in src/dfa.c

bug-grep

From:	Paolo Bonzini
Subject:	Re: [PATCH 5/5] Small refactoring in src/dfa.c
Date:	Mon, 08 Mar 2010 12:53:13 +0100
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1

On 03/08/2010 10:51 AM, Jim Meyering wrote:

Paolo Bonzini wrote:

* src/dfa.c (parse_bracket_exp_mb): Return MBCSET.
(lex): Assign return value of parse_bracket_exp_mb to lasttok, return it.


Looks fine and saves a line.
ACK.


I have bigger plans than saving a line. :->

(Like doing almost all the Red Hat egf-speedup patch does, and many morethings it does not do...)


Paolo

Current Thread

[Next in Thread]

[PATCH 1/5] remove register keywords, (continued)
- [PATCH 1/5] remove register keywords, Paolo Bonzini, 2010/03/07
  - Re: [PATCH 1/5] remove register keywords, Jim Meyering, 2010/03/08
- [PATCH 2/5] remove register variable hacks, Paolo Bonzini, 2010/03/07
  - Re: [PATCH 2/5] remove register variable hacks, Jim Meyering, 2010/03/08
- [PATCH 4/5] use do...while(0) idiom, Paolo Bonzini, 2010/03/07
  - Re: [PATCH 4/5] use do...while(0) idiom, Jim Meyering, 2010/03/08
- [PATCH 3/5] extract common code from if/else, Paolo Bonzini, 2010/03/07
  - Re: [PATCH 3/5] extract common code from if/else, Jim Meyering, 2010/03/08
- [PATCH 5/5] Small refactoring in src/dfa.c, Paolo Bonzini, 2010/03/07
  - Re: [PATCH 5/5] Small refactoring in src/dfa.c, Jim Meyering, 2010/03/08
    - Re: [PATCH 5/5] Small refactoring in src/dfa.c, Paolo Bonzini <=