Re: [PATCH 04/17] dfa: remove CRANGE dead code

bug-grep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/17] dfa: remove CRANGE dead code

From:	Jim Meyering
Subject:	Re: [PATCH 04/17] dfa: remove CRANGE dead code
Date:	Fri, 12 Mar 2010 19:11:05 +0100

Paolo Bonzini wrote:
> The only use of CRANGE was removed by commit 193830d.  In theory it is
> more correct to do what CRANGE did, but in practice it seems like it did
> not work.
>
> * src/dfa.h (token): Remove CRANGE.
> * src/dfa.c (atom): Do not handle CRANGE.
> (prtok): Likewise.

Can't argue with dead-code-removal.
ACK.

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/16] my last hefty patch drop, Paolo Bonzini, 2010/03/12
- [PATCH 01/17] kwset/system: remove ptr_t, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 01/17] kwset/system: remove ptr_t, Jim Meyering, 2010/03/12
- [PATCH 02/17] grep: cleanup one const cast, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 02/17] grep: cleanup one const cast, Jim Meyering, 2010/03/12
- [PATCH 03/17] dfa: get rid of x*alloc, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 03/17] dfa: get rid of x*alloc, Jim Meyering, 2010/03/12
    - Re: [PATCH 03/17] dfa: get rid of x*alloc, Paolo Bonzini, 2010/03/12
- [PATCH 04/17] dfa: remove CRANGE dead code, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 04/17] dfa: remove CRANGE dead code, Jim Meyering <=
- [PATCH 05/17] dfa, grep: cleanup if-before-free and cast-of-argument-to-free, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 05/17] dfa, grep: cleanup if-before-free and cast-of-argument-to-free, Jim Meyering, 2010/03/12
- [PATCH 07/17] syntax-check: enable makefile-TAB-only-indentation, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 07/17] syntax-check: enable makefile-TAB-only-indentation, Jim Meyering, 2010/03/12
- [PATCH 06/17] grep: fix error-message-uppercase, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 06/17] grep: fix error-message-uppercase, Jim Meyering, 2010/03/12
- [PATCH 09/17] syntax-check: enable space-tab, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 09/17] syntax-check: enable space-tab, Jim Meyering, 2010/03/12
- [PATCH 08/17] syntax-check: enable m4-quote-check, Paolo Bonzini, 2010/03/12
  - Re: [PATCH 08/17] syntax-check: enable m4-quote-check, Jim Meyering, 2010/03/12

Prev by Date: Re: [PATCH 05/17] dfa, grep: cleanup if-before-free and cast-of-argument-to-free
Next by Date: Re: [PATCH 07/17] syntax-check: enable makefile-TAB-only-indentation
Previous by thread: [PATCH 04/17] dfa: remove CRANGE dead code
Next by thread: [PATCH 05/17] dfa, grep: cleanup if-before-free and cast-of-argument-to-free
Index(es):
- Date
- Thread