Re: [PATCH] tests: clean up fedora.sh

[Jim Meyering]

Jim Meyering wrote:

> Paolo Bonzini wrote:
>
>> On 03/14/2010 12:18 PM, Jim Meyering wrote:
>>> The new fedora.sh test was annoyingly slow.
>>> Yeah, 3 seconds is "slow" for some of us ;-)
>>>
>>> This fixes it, along with a little clean up and concurrency-protection.
>>> It relies on the "timeout" program[0], but if it's not available,
>>> the three sub-tests that require that are silently skipped.
>>
>> Good!  Can you rename it to just "fedora" so that we can have the
>> convention that ".sh" implies having to convert to the new testsuite?
>
> I've just done that, and fixed a small problem along the way:
...
>>From f9576e961326243641bd6d23eee1b9c0a887bb34 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Mon, 15 Mar 2010 10:10:25 +0100
> Subject: [PATCH 2/2] * tests/fedora.sh: Rename to...
>
> * tests/fedora: ...this, to reflect new convention:
> Use the lack of a suffix to indicate we've converted to the new
> init.sh-using test framework.
>
> tests: adjust fedora.sh to handle traps more portably
> ---
>  tests/{fedora.sh => fedora} |    0
>  1 files changed, 0 insertions(+), 0 deletions(-)
>  rename tests/{fedora.sh => fedora} (100%)
>
> diff --git a/tests/fedora.sh b/tests/fedora
> similarity index 100%
> rename from tests/fedora.sh
> rename to tests/fedora

Oh, rats.
That was obviously incomplete.
Here's the remainder of the patch.
Sorry about that.

>From 51b351e67bb0eb24fd19ac75f6037408ceb24f58 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 15 Mar 2010 10:26:41 +0100
Subject: [PATCH] tests: complete the renaming fedora.sh -> fedora

* tests/Makefile.am (TESTS): Rename fedora.sh -> fedora here, too.
---
 tests/Makefile.am |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 5d3a4a8..fe14342 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -22,6 +22,7 @@ TESTS =                                               \
   dfaexec-multibyte                            \
   empty.sh                                     \
   ere.sh                                       \
+  fedora                                       \
   file.sh                                      \
   fmbtest.sh                                   \
   foad1.sh                                     \
@@ -35,8 +36,7 @@ TESTS =                                               \
   status.sh                                    \
   warning.sh                                   \
   word-multi-file                              \
-  yesno.sh                                     \
-  fedora.sh
+  yesno.sh

 EXTRA_DIST =                                   \
   $(TESTS)                                     \
--
1.7.0.2.398.g10c2f