Re: [PATCH 6/9] dfa: cache MB_CUR_MAX for dfaexec

[Paolo Bonzini]

> > +static void
> > +free_mbdata (struct dfa *d)
> > +{
> > +  int i;
>
> Since I and J are always non-negative,
> please declare them as "unsigned int".

Done.

> I realize all of the other "counter-style" (or otherwise guaranteed
> to be non-negative) members have type "int", but that is wrong.
> They should all use unsigned types.
>
> So please start by making mb_cur_max be "unsigned int".

Done.

> >     /* These stuff are used only if MB_CUR_MAX>  1 or multibyte environments.  
> > */
>
> While you're there, you might want to 's/These stuff/The following/'

See the other patch I sent; I pushed both.

Thanks.

Paolo