[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/9] remove most {,E,F}GREP_PROGRAM occurrences
From: |
Jim Meyering |
Subject: |
Re: [PATCH 0/9] remove most {,E,F}GREP_PROGRAM occurrences |
Date: |
Fri, 19 Mar 2010 14:45:02 +0100 |
Paolo Bonzini wrote:
> This patchset removes all occurrences of {,E,F}GREP_PROGRAM outside grep.c.
> #ifdefs are avoided by splitting search.c into multiple files and letting
> the linker drop those that are not used. I tested that there is basically
> no change in executable size for any of {,e,f}grep.
>
> I have one that removes the remaining occurrences, but it introduces new
> strings so it would require another snapshot before submitting the .POT
> file to the translation project.
>
> Paolo Bonzini (9):
> grep: remove getpagesize.h
> grep: remove one #ifdef
> grep: change struct matcher termination
> grep: make egrep/fgrep use struct matcher
> grep: eliminate {COMPILE,EXECUTE}_{RET,ARGS,FCT}
> grep: remove one #ifdef
> grep: split search.c
> grep: prepare for libification of *search.c
> grep: libify *search.c
My first step was to apply them:
$ git am t.?
Applying: grep: remove getpagesize.h
Applying: grep: remove one #ifdef
Applying: grep: change struct matcher termination
Applying: grep: make egrep/fgrep use struct matcher
/home/j/w/co/grep/.git/rebase-apply/patch:36: new blank line at EOF.
+
/home/j/w/co/grep/.git/rebase-apply/patch:49: new blank line at EOF.
+
/home/j/w/co/grep/.git/rebase-apply/patch:164: new blank line at EOF.
+
warning: 3 lines add whitespace errors.
Applying: grep: eliminate {COMPILE,EXECUTE}_{RET,ARGS,FCT}
Applying: grep: remove one #ifdef
Applying: grep: split search.c
Applying: grep: prepare for libification of *search.c
Applying: grep: libify *search.c
Would you please remove those trailing blank lines?
- [PATCH 6/9] grep: remove one #ifdef, (continued)
- [PATCH 6/9] grep: remove one #ifdef, Paolo Bonzini, 2010/03/19
- [PATCH 8/9] grep: prepare for libification of *search.c, Paolo Bonzini, 2010/03/19
- [PATCH 9/9] grep: libify *search.c, Paolo Bonzini, 2010/03/19
- [PATCH 7/9] grep: split search.c, Paolo Bonzini, 2010/03/19
- Re: [PATCH 0/9] remove most {,E,F}GREP_PROGRAM occurrences,
Jim Meyering <=
- Re: [PATCH 0/9] remove most {,E,F}GREP_PROGRAM occurrences, Jim Meyering, 2010/03/19
- Re: [PATCH 0/9] remove most {,E,F}GREP_PROGRAM occurrences, Jim Meyering, 2010/03/19
- Re: [PATCH 0/9] remove most {,E,F}GREP_PROGRAM occurrences, Jim Meyering, 2010/03/22