[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/9] grep: remove one #ifdef
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 2/9] grep: remove one #ifdef |
|
Date: |
Fri, 19 Mar 2010 15:22:02 +0100 |
On Fri, Mar 19, 2010 at 14:51, Jim Meyering <address@hidden> wrote:
> Paolo Bonzini wrote:
>> * search.c (Ecompile): Always go through GEAcompile.
>
> This lazy^W time-constrained reviewer doesn't see off-hand why
> you're doing this, or why it's ok. I presume it's a no-semantic-change.
Yes, this way it goes through the same code path for both grep and
egrep. For the next patches in the series, it makes sense because
Ecompile becomes a 1-line function I can move to esearch.c, instead of
a stripped-down version of GEAcompile.
Paolo
- [PATCH 0/9] remove most {,E,F}GREP_PROGRAM occurrences, Paolo Bonzini, 2010/03/19
- [PATCH 1/9] grep: remove getpagesize.h, Paolo Bonzini, 2010/03/19
- [PATCH 2/9] grep: remove one #ifdef, Paolo Bonzini, 2010/03/19
- [PATCH 3/9] grep: change struct matcher termination, Paolo Bonzini, 2010/03/19
- [PATCH 4/9] grep: make egrep/fgrep use struct matcher, Paolo Bonzini, 2010/03/19
- [PATCH 5/9] grep: eliminate {COMPILE,EXECUTE}_{RET,ARGS,FCT}, Paolo Bonzini, 2010/03/19
- [PATCH 6/9] grep: remove one #ifdef, Paolo Bonzini, 2010/03/19
- [PATCH 8/9] grep: prepare for libification of *search.c, Paolo Bonzini, 2010/03/19