[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] build: avoid link failure on systems using gnulib's fcntl but no
From: |
Jim Meyering |
Subject: |
[PATCH] build: avoid link failure on systems using gnulib's fcntl but not open |
Date: |
Sun, 21 Mar 2010 18:39:30 +0100 |
I noticed this build failure for grep:
http://hydra.nixos.org/build/329919
CCLD grep
Undefined symbols:
"_rpl_open", referenced from:
_grepfile in grep.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[2]: *** [grep] Error 1
I fixed it with this change to grep, and do appreciate
the implied warning that grep needs the "open" module,
but this must be a bug in gnulib...
>From 8f7343014eb45173a07e044aa7c5875ea745ce56 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 21 Mar 2010 18:36:52 +0100
Subject: [PATCH] build: avoid link failure on systems using gnulib's fcntl but
not open
* bootstrap.conf (gnulib_modules): Using gnulib's fcntl module
and including <fcntl.h>, but not also using gnulib's "open" module
would result in link failure due to references to rpl_open
on systems requiring the replacement (e.g., Cygwin and Darwin).
---
bootstrap.conf | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 2cdcefa..01af676 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -51,6 +51,7 @@ mbrtowc
memchr
mempcpy
obstack
+open
progname
quotearg
realloc
--
1.7.0.2.486.gfdfcd
- [PATCH] build: avoid link failure on systems using gnulib's fcntl but not open,
Jim Meyering <=