Re: [patch #7132] Small change to grep-2.6

[Paolo Bonzini]

> I post patches of small change to grep-2.6.

Thanks!

> diff1:
>    I seem that It should match at the head of the line when start_ptr
>    isn't set.

Do you have a testcase?  I'm hesitant to apply this without one.

> diff2:
>    We don't have to convert text to lower-case in MB_CUR_MAX>  1.

Ok, I made a matching change to the XXX comment.  However, maybe we have 
to provide instead a !MBS_SUPPORT version of mbtolower, and use it 
unconditionally?

> diff3:
>    When MBS_SUPPORT isn't defined, MB_CUR_MAX mayn't be defined.

Ok.

> diff4:
>    We treat an invalid sequence or a truncated multibyte character as a
>    single byte character, mbstate may need to be reset.

I'm not sure it matters for is_mb_middle, but I applied it anyway.

diff5 is ok too, but I made some changes there.

Would you mind reviewing the patches I posted to the mailing list?

Paolo