Re: [PATCH v3] dfa/grep: fix compilation with MBS_SUPPORT

[Paolo Bonzini]

On Thu, Mar 25, 2010 at 19:17, Eric Blake <address@hidden> wrote:
> On 03/25/2010 06:38 AM, Paolo Bonzini wrote:
>>  static void
>> -setbit_case_fold (wint_t b, charclass c)
>> +setbit_case_fold (
>> +#ifdef MBS_SUPPORT
>> +                  wint_t b,
>> +#else
>> +                  unsigned int b,
>> +#endif
>> +                  charclass c)
>>  {
>
> This looks kind of awkward.  Could we instead do:
>
> #ifdef MBS_SUPPORT
> typedef grep_wint wint_t;
> #else
> typedef grep_wint unsigned int;
> #endif
>
> static void
> setbit_case_fold (grep_wint b, charclass c)
> {

I thought about it, but this hack is not going to last enough to worry...

Paolo