[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix -Wformat failure
From: |
Jim Meyering |
Subject: |
Re: [PATCH] tests: fix -Wformat failure |
Date: |
Wed, 31 Mar 2010 12:06:47 +0200 |
Paolo Bonzini wrote:
> * tests/get-mb-cur-max (main): Cast MB_CUR_MAX to int.
> ---
> tests/get-mb-cur-max.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/get-mb-cur-max.c b/tests/get-mb-cur-max.c
> index 3ba7389..48e2713 100644
> --- a/tests/get-mb-cur-max.c
> +++ b/tests/get-mb-cur-max.c
> @@ -29,7 +29,7 @@ main (int argc, char **argv)
> set_program_name (argv[0]);
> if (setlocale (LC_ALL, argv[1]))
> {
> - printf ("%d\n", MB_CUR_MAX);
> + printf ("%d\n", (int) MB_CUR_MAX);
> exit (EXIT_SUCCESS);
Oh, I see you already posted this.
I did that at first, too.
However, since MB_CUR_MAX is size_t,
on principle, I changed to unsigned.
The documented return values are all positive, too.
But it probably never matters in practice, so go ahead and push yours.