Re: Tests erroneously assume

[Ludovic Courtès]

Hi Jim,

Jim Meyering <address@hidden> writes:

> Ludovic Courtès wrote:
>> This commit [0] assumes that the ‘en_US.UTF-8’ locale is available.
>> This breaks Hydra builds [1] because the only locale available there is C.
>>
>> I think ‘configure’ should check for this locale, just like it checks
>> for a french locale, etc.
>>
>> [0] 
>> http://git.savannah.gnu.org/cgit/grep.git/diff/?id=3220317a428d63a4303ffee0fb45becf835cf1fd&id2=90cc2ba27bd3f368b945f89a60be4220b73baac7
>> [1] http://hydra.nixos.org/build/332654
>
> Hi Ludovic,
>
> Thanks for the reminder.  This should fix it.
> Can you easily/quickly test this pair of commits?

They fix the problem:

--8<---------------cut here---------------start------------->8---
SKIP: char-class-multibyte (exit: 77)
=====================================

char-class-multibyte: skipped test: en_US.UTF-8 locale not found
--8<---------------cut here---------------end--------------->8---

Now I’m seeing this failure:

--8<---------------cut here---------------start------------->8---
FAIL: include-exclude (exit: 1)
===============================

--- out 2010-04-01 10:23:01.000000000 +0000
+++ exp-a       2010-04-01 10:23:01.000000000 +0000
@@ -1,2 +1 @@
-x/dir/d:d
-x/b:b
+x/a:a
--8<---------------cut here---------------end--------------->8---

Running the test with sh -x shows that it comes from the last test:

--8<---------------cut here---------------start------------->8---
+ grep -r '--include=a*' . x
+ compare out exp-a
+ diff -u out exp-a
--8<---------------cut here---------------end--------------->8---

Thanks,
Ludo’.