|
| From: | Paolo Bonzini |
| Subject: | Re: [PATCH] Avoid polluting cygwin namespace. |
| Date: | Wed, 07 Apr 2010 00:19:29 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3 |
On 04/06/2010 11:57 PM, Bruno Haible wrote:
Instead, let's look more closely at the original problem:<windows.h>
defines WCHAR to a type, whereas grep/src/dfa.h uses it as an enum item.
The proposed workaround would not completely fix this problem: It would
solve it for Cygwin only, but not for mingw.
I would instead propose to add to dfa.h two lines:
/*<windows.h> defines WCHAR as a type. */
#undef WCHAR
We already fixed it in grep, indeed. The fix is not needed anymore, it was just proposed as a cosmetic issue. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |