[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Suggested patch: move dfa internals into dfa.c
|
From: |
Paolo Bonzini |
|
Subject: |
Re: Suggested patch: move dfa internals into dfa.c |
|
Date: |
Wed, 07 Apr 2010 21:05:17 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3 |
On 04/07/2010 08:49 PM, Aharon Robbins wrote:
Attached is a patch formatted per the HACKING file's instructions. It's
my*very first* use of git, so be kind.
Not bad at all, just format the commit message like this: one-line
summary ("move dfa internals into dfa.c"), blank line, changelog.
This avoids that the patch is formatted like this:
Subject: [PATCH] dfa.h: Moved essentially all the dfa internals out of
dfa.h. New routines added as needed.
dfa.c: The dfa internals are now totally local to this file. A few new
routines added for access to features.
dfasearch.c: Modified for changes in interface.
Paolo