[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 0/3] bug #30771 and related
From: |
Paolo Bonzini |
Subject: |
[RFC PATCH 0/3] bug #30771 and related |
Date: |
Sun, 15 Aug 2010 10:57:57 -0400 |
Hi all,
this is a patch to fix the worst part of bug #30771 (the segfault).
The segfault could also be reproduced by passing a zero-sized file or
/dev/null as the input file, and I opted for the latter.
I added a second test, which I marked as an expected failure, to test
that grep fails when a directory is passed to "grep -f".
The problem is that I could not make the test fail, because the segfault
is strangely not seen if the "grep -Fif /dev/null" command is run from
a script.
Help completing the patch is thus welcome (together with reviews for the
other patches that have been posted).
Paolo
Paolo Bonzini (3):
search: fix "grep -Fif /dev/null"
tests: add test for previous commit
tests: add failing test for grep from a directory
bootstrap.conf | 1 +
src/searchutils.c | 11 ++++++-----
src/system.h | 1 +
tests/Makefile.am | 5 ++++-
tests/grep-dev-null | 15 +++++++++++++++
tests/grep-dir | 17 +++++++++++++++++
6 files changed, 44 insertions(+), 6 deletions(-)
create mode 100644 tests/grep-dev-null
create mode 100644 tests/grep-dir
- [RFC PATCH 0/3] bug #30771 and related,
Paolo Bonzini <=