[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch #6569] Allow grep to work in small stack environment
From: |
Jim Meyering |
Subject: |
Re: [patch #6569] Allow grep to work in small stack environment |
Date: |
Sat, 28 Aug 2010 00:04:00 +0200 |
Paul Eggert wrote:
> On 08/27/2010 01:39 AM, Jim Meyering wrote:
>
>> - use xnmalloc, not malloc+test+return, so we don't ignore malloc failure.
>> - use sizeof *VAR, not "sizeof TYPE" -- the former is more maintainable.
>> - adjust indentation to retain declaration alignment
>
> There are many places in other GNU apps, including gnulib, where
> it's assumed that one can declare a 4 kB-or-so array on the stack without
> any problem. So I'm surprised to see the need for this change to GNU grep.
> Surely we don't need to go through GNU apps and rejigger things for
> configurations with 4 kB stacks? By today's standards, such stacks are
> ridiculously small.
Patrick,
For our reference, on what system does this change help you?