[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] version: fix copyright year
From: |
Jim Meyering |
Subject: |
Re: [PATCH] version: fix copyright year |
Date: |
Mon, 30 Aug 2010 13:06:24 +0200 |
Paolo Bonzini wrote:
> On 08/30/2010 12:25 PM, Jim Meyering wrote:
>> Also, in general,
>> when an author's name has a translation, proper_name provides
>> functionality that some think is worthwhile: it returns
>> "TRANSLATION (NAME)", where "NAME" is the original ASCII argument.
>
> Ugh, this could be done with a simple TRANSLATORS comment. In sed,
> proper_name brought in a bunch of iconv-related stuff that wasn't used
> before, which is why I asked the question. Anyway, if this is the
> standard let's go with it.
Dunno about standard, but it's what's done in coreutils,
diffutils, m4, tar, findutils, and more.
It does make grep use some new code, though not much.
One potential gotcha with this change: the new modules require
that we regenerate some lib/*.h files, so if you have an existing
built-from-git working directory, you'll get a new link error
(even after ./bootstrap && ./configure ... && make)
unless you first run "make distclean" or otherwise force
regeneration of the offending files.
This doesn't affect people who build from a distribution tarball,
only those who build from git-cloned sources.