|
From: | Paolo Bonzini |
Subject: | Re: [PATCH] fall back to glibc matcher if a MBCSET is found |
Date: | Mon, 13 Sep 2010 11:24:48 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5 |
On 09/13/2010 11:20 AM, Jim Meyering wrote:
Note that the test is unconditionally XFAILed unless you use --without-included-regex.Using --without-included-regex is risky, because it tells grep to use the libc-supplied regex functions, no matter how many flaws they have -- flaws that would be avoided if it*did* use the package-provided version.
Yes, that's why I preferred to push the gnulib change and avoid mentioning --without-included-regex.
The problem with the gnulib regex module is that you have to balance the features of the system regex, and the known stability of the gnulib module. It's hard to do.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |