bug-grep
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] tests: tiny simplification in TESTS_ENVIRONMENT definiti

From: Stefano Lattarini
Subject: Re: [PATCH 2/3] tests: tiny simplification in TESTS_ENVIRONMENT definition
Date: Mon, 10 Oct 2011 15:12:41 +0200
User-agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) 
On Monday 10 October 2011, Paolo Bonzini wrote:
> On 10/10/2011 02:32 PM, Stefano Lattarini wrote:
> > * tests/Makefile.am (TESTS_ENVIRONMENT): Remove redundant use of
> > `export'.
> > ---
> >   tests/Makefile.am |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Why redundant?
> 
Because all the definitions in TESTS_ENVIRONMENT are already being
exported:

  TESTS_ENVIRONMENT =                             \
    tmp__=$$TMPDIR; test -d "$$tmp__" || tmp__=.; \
    TMPDIR=$$tmp__; export TMPDIR;                \
    export                                        \
    VERSION='$(VERSION)'                          \
    ...                                           \
    MAKE=$(MAKE)                                  \
    MALLOC_PERTURB_=$(MALLOC_PERTURB_) ...

Regards,
  Stefano
reply via email to
[Prev in Thread] Current Thread [Next in Thread]