Re: Problems building 1.22.2 on Solaris with vendor compiler

[Werner LEMBERG]

Hello Albert!


> I've tried building groff-1.22.2 on Solaris with the vendor compiler:
>   ...
>   "env.cpp", line 22:
>     Error: Could not open include file <src/libs/gnulib/config.h>.

Line 22?  Are you sure?  This corresponds to

  #include "dictionary.h"

which doesn't fit the error message at all.  Either the line number is
incorrect, or the Solaris compiler has a bug...  Or maybe you aren't
using the upstream version of groff but a patched one?

> So, should we modify env.cpp and any other file with the above
> problem to #include "src/libs/gnulib/config.h" and -I$(top_builddir)
> as the solution?

I very much dislike this.  As far as I know, this is not how gnulib
should be used.  The `wcwidth' module gets provided as a drop-in (via
`libgnu.a') in case the functionality is not provided by the OS, and
by including the standard `wchar.h' header (via `-I
src/libs/gnulib/lib'), everything should be fine.  In particular,
`config.h' should *not* be included.  Calling gnulib-tool, you see
messages like below; the example is for `strdup':

  You may need to add #include directives for the following .h files.
    #include <string.h>

  Don't forget to
    - add "lib/Makefile" to AC_CONFIG_FILES in ./configure.ac,
    - mention "lib" in SUBDIRS in Makefile.am,
    - mention "-I m4" in ACLOCAL_AMFLAGS in Makefile.am,
    - invoke gl_EARLY in ./configure.ac, right after AC_PROG_CC,
    - invoke gl_INIT in ./configure.ac.

The issue looks like a gnulib bug.  Can you report it there, CCing me
(or the groff list)?


    Werner