[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[Deri James]

Follow-up Comment #6, bug#65112 (group groff):

Apologies for the brevity, it was one of those "go to bed and wake up bolt
upright with the answer", just wanted you to confirm the fix was good. Now the
explanation:-

Type 1 fonts have a section of numbered subroutines which can be called from
the actual glyph definition, I have seen over 1000 in some large fonts. So,
when you are subsetting you need to subset (and renumber) any relevent
subroutines used by the glyph you are subsetting.

What went wrong (only with your version of the Symbol font) was that the
required subroutines were not making it to the subsetted font. Usually
including a subroutine is simple: a number is pushed onto the stack and
"callsubr" is called, but in this font it users this form:-

        22 1 3 callothersubr
        pop
        callsubr

The number popped is actually 22 so it is this subroutine which needs to be
included.

It is interesting that of the 4 different versions of the Symbol font I looked
at, it is only the oldest (yours) which used this form:-

Your version:- (s050000l.pfb)

%!PS-AdobeFont-1.0: StandardSymL 001.005
%%CreationDate: Thu Oct 21 1999
% Copyright URW Software, Copyright 1997 by URW
% URW Software, Copyright 1997 by URW
% See the file COPYING (GNU General Public License) for license conditions.

Bookworm:- (StandardSymbolsPS)

%!PS-AdobeFont-1.0: StandardSymbolsPS 2.00
%%CreationDate: Tue May 31 2016
% Copyright URW Software, Copyright 2015 by URW
% URW Software, Copyright 2015 by URW

Buster?:- (StandardSymbolsPS)

%!PS-AdobeFont-1.0: StandardSymbolsPS 2.00
%%CreationDate: Tue May 31 2016
% Copyright URW Software, Copyright 2015 by URW
% URW Software, Copyright 2015 by URW

Mageia 9:- (s050000l.pfb)

%!PS-AdobeFont-1.0: StandardSymL 001.005_%{version}-%{release}
%%Title: StandardSymL
%Version: 001.005_%{version}-%{release}
%%CreationDate: Wed Mar 30 23:15:51 2022
%%Creator: Unknown
%Copyright: Copyright URW Software, Copyright 1997 by URW
% Generated by FontForge 20201107 (http://fontforge.sf.net/)

I don't know if this will make it onto the website, but it should send the
email. I hope this helps you write a commit message.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65112>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/