[bug #46470] [troff] global out of bounds read in troff in function make_glyph_node

[G. Branden Robinson]

Update of bug #46470 (group groff):

                  Status:                    None => Fixed
             Assigned to:                    None => gbranden
             Open/Closed:                    Open => Closed
         Planned Release:                    None => 1.24.0
                 Summary: Global out of bounds read in troff in function
make_glyph_node => [troff] global out of bounds read in troff in function
make_glyph_node

    _______________________________________________________

Follow-up Comment #4:

The out-of-bounds read seems to have been resolved prior to _groff_ 1.23.0,
per Bjarni in comment #2.

The spurious/misleading diagnostic, I fixed a couple of months ago,
collaterally to a similar problem I worked on.


commit dec7d527753495df72fcfac33ac98248b9f3e9fd
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Aug 19 12:52:31 2024 -0500

    [troff]: Suppress warning when redundant.
    
    * src/roff/troff/node.cpp (make_glyph_node): Don't throw a warning if
      `get_char_for_escape_parameter()` in "input.cpp" already threw an
      error for the same input token.  Also compare array elements of `const
      char` type to character, not integer, literals.
    
    Before:
    
    $ printf '\\(\001' | nroff -z
    troff:<standard input>:1: error: a leader character is not allowed in an
escape sequence parameter
    troff:<standard input>:1: warning: special character '' not defined
    
    Now:
    
    $ printf '\\(\001' | ./build/test-groff -T ascii -z
    troff:<standard input>:1: error: a leader character is not allowed in an
escape sequence parameter



$ printf '\\(' | ./build/test-groff -aT utf8 
troff: error: end of input in escape sequence
<beginning of page>





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?46470>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature