[bug #66526] GNU troff misinterprets conditional expressions starting with `|`

[G. Branden Robinson]

Update of bug #66526 (group groff):

                  Status:             In Progress => Fixed
             Open/Closed:                    Open => Closed
         Planned Release:                    None => 1.24.0

    _______________________________________________________

Follow-up Comment #2:

Thanks, Dave.  Who knows, maybe some day that Platonic dialogue will get a
Norton Critical Edition.


commit ea1e00de47b376560267b9e1390ee2613fdedccf
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Dec 4 04:31:34 2024 -0600

    [troff]: Fix Savannah #66526 (`|` handling).
    
    * src/roff/troff/input.cpp (is_conditional_expression_true): Stop
      treating `|` as a delimiter, but instead as beginning a numeric
      expression, _only_ as the predicate of a control structure request.
      Improves compatibility with AT&T troff, including DWB 3.3 and Heirloom
      Doctools.  Problem appears to date back to groff 1.02.
    
      GNU troff has long thrown diagnostics in this context, of increasing
      detail in recent years.  For example:
    
      troff:mm/0.MT:271: warning: missing closing delimiter in output
        comparison operator; expected character '|', got a newline
    
      However, this was easily overlooked in our automated tests because it
      didn't break formatting, except on Solaris 10 (or if you ran the
      post-1.23.0 test "contrib/mm/tests/memoranda-format-correctly.sh"
      with an older groff release).
    
    Fixes <https://savannah.gnu.org/bugs/?66526>.


There's a minor factual error in the penultimate paragraph ("However"); I'll
push a fix to the ChangeLog.  The formatting wasn't broken at all (though
there are scenarios where it could have been, heretofore never complained
about AFAIK).  The problem was Solaris _cksum_(1) not behaving like everyone
else's.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66526>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature