[bug #56589] grub-2.04/grub-core/fs/btrfs.c:695]: (style) Array index 'i' is used before limits check.

[David Binderman]

URL:
  <https://savannah.gnu.org/bugs/?56589>

                 Summary: grub-2.04/grub-core/fs/btrfs.c:695]: (style) Array
index 'i' is used before limits check.
                 Project: GNU GRUB
            Submitted by: dcb314
            Submitted on: Sun 07 Jul 2019 04:36:55 PM UTC
                Category: None
                Severity: Major
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: other
         Reproducibility: None
         Planned Release: None

    _______________________________________________________

Details:


Source code is

  for(i = 0; buffers[i].data_is_valid && i < nstripes; i++);

maybe better code

  for(i = 0; i < nstripes && buffers[i].data_is_valid; i++);





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?56589>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/