[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28590: [PATCH 4/7] weak-table: Always unregister previous links when
From: |
Ludovic Courtès |
Subject: |
bug#28590: [PATCH 4/7] weak-table: Always unregister previous links when inserting an entry. |
Date: |
Tue, 3 Oct 2017 13:43:49 +0200 |
* libguile/weak-table.c (weak_table_put_x): Always call
'unregister_disappearing_links' before returning.
---
libguile/weak-table.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libguile/weak-table.c b/libguile/weak-table.c
index 7d8633165..b5db3ef48 100644
--- a/libguile/weak-table.c
+++ b/libguile/weak-table.c
@@ -731,9 +731,9 @@ weak_table_put_x (scm_t_weak_table *table, unsigned long
hash,
return;
}
- if (entries[k].hash)
- unregister_disappearing_links (&entries[k], table->kind);
- else
+ unregister_disappearing_links (&entries[k], table->kind);
+
+ if (!entries[k].hash)
table->n_items++;
entries[k].hash = hash;
--
2.14.2
- bug#28590: [PATCH 0/7] Attempt to reduce memory growth, Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 6/7] weak-table: 'rob_from_rich' accounts for disappeared entries., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 7/7] weak-table: Resize less frequently., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 3/7] weak-table: Make sure 'move_disappearing_links' actually moves links., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 2/7] weak-table: Stress the GC a little less when resizing., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 1/7] weak-table: Fix unbounded growth of the disappearing link table., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 5/7] weak-table: 'move_weak_entry' reports disappeared links., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 4/7] weak-table: Always unregister previous links when inserting an entry.,
Ludovic Courtès <=
- bug#28590: [PATCH 0/7] Attempt to reduce memory growth, Ludovic Courtès, 2017/10/04