Re: [PATCH] package: allow users to upgrade the whole system by not providing a regexp.

[Ludovic Courtès]

Cyril Roelandt <address@hidden> skribis:

> 'guix package --upgrade' is now the same as "guix package --upgrade=''".

[...]

> -        (option '(#\u "upgrade") #t #f
> +        (option '(#\u "upgrade") #f #f

Should be #f #t (the first one is ‘required?’, the second one is
‘optional?’, see SRFI-37.)

> @@ -602,7 +602,9 @@ Install, remove, or upgrade PACKAGES in a single 
> transaction.\n"))
>          (let* ((installed (manifest-packages (profile-manifest profile)))
>                 (upgrade-regexps (filter-map (match-lambda
>                                               (('upgrade . regexp)
> -                                              (make-regexp regexp))
> +                                              (if regexp
> +                                               (make-regexp regexp)
> +                                               (make-regexp "")))

Rather: (make-regexp (or regexp "")).

Could you also update the manual?

Thanks!

Ludo’.