[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32681: OpenBLAS with ILP64 storage model
From: |
Eric Brown |
Subject: |
bug#32681: OpenBLAS with ILP64 storage model |
Date: |
Thu, 13 Sep 2018 09:16:12 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Should we write it as:
>
> (package
> (inherit openblas)
> …)
>
> ? That would avoid duplication with the ‘openblas’ package.
>
> Also, should we add a ‘supported-systems’ field to restrict builds to
> x86_64-linux, aarch64-linux, and mips64el-linux?
>
> Apart from that it LGTM.
>
> Thanks for the patch!
>
> Ludo’.
Hi Ludo',
Please find a patch attached which incorporates your suggestions.
Best regards,
Eric
>From 08ec9c94431af425d5dfc2cafc428bee10904ff6 Mon Sep 17 00:00:00 2001
From: Eric Brown <address@hidden>
Date: Thu, 13 Sep 2018 08:54:36 -0500
Subject: [PATCH] openblas-ilp64: Add support for the ILP64 storage model.
* gnu/packages/maths.scm (openblas-ilp64): New variable.
---
gnu/packages/maths.scm | 59 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 59 insertions(+)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index af41093fb..7f1034dc4 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -27,6 +27,7 @@
;;; Copyright © 2018 Nadya Voronova <address@hidden>
;;; Copyright © 2018 Adam Massmann <address@hidden>
;;; Copyright © 2018 Marius Bakke <address@hidden>
+;;; Copyright © 2018 Eric Brown <address@hidden>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2873,6 +2874,64 @@ parts of it.")
"OpenBLAS is a BLAS library forked from the GotoBLAS2-1.13 BSD version.")
(license license:bsd-3)))
+(define-public openblas-ilp64
+ (package (inherit openblas)
+ (name "openblas-ilp64")
+ (version "0.3.2")
+ (supported-systems (list
+ "x86_64-linux"
+ "aarch64-linux"
+ "mips64el-linux"))
+ (arguments
+ `(#:test-target "test"
+ ;; DYNAMIC_ARCH is only supported on x86. When it is disabled and no
+ ;; TARGET is specified, OpenBLAS will tune itself to the build host, so
+ ;; we need to disable substitutions.
+ #:substitutable?
+ ,(let ((system (or (%current-target-system) (%current-system))))
+ (or (string-prefix? "x86_64" system)
+ (string-prefix? "mips" system)
+ (string-prefix? "aarch64" system)))
+ #:make-flags
+ (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+ "SHELL=bash"
+ ;; Build the library for all supported CPUs. This allows
+ ;; switching CPU targets at runtime with the environment variable
+ ;; OPENBLAS_CORETYPE=<type>, where "type" is a supported CPU type.
+ ;; Unfortunately, this is not supported on non-x86 architectures,
+ ;; where it leads to failed builds.
+ "INTERFACE64=1"
+ "LIBNAMESUFFIX=ilp64"
+ ,@(let ((system (or (%current-target-system) (%current-system))))
+ (cond
+ ((string-prefix? "x86_64" system)
+ '("DYNAMIC_ARCH=1"))
+ ;; On MIPS we force the "SICORTEX" TARGET, as for the other
+ ;; two available MIPS targets special extended instructions
+ ;; for Loongson cores are used.
+ ((string-prefix? "mips" system)
+ '("TARGET=SICORTEX"))
+ ;; On aarch64 force the generic 'armv8-a' target
+ ((string-prefix? "aarch64" system)
+ '("TARGET=ARMV8"))
+ (else '()))))
+ ;; no configure script
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (add-before 'build 'set-extralib
+ (lambda* (#:key inputs #:allow-other-keys)
+ ;; Get libgfortran found when building in utest.
+ (setenv "FEXTRALIB"
+ (string-append "-L" (assoc-ref inputs "fortran-lib")
+ "/lib"))
+ #t)))))
+ (synopsis "Optimized BLAS library based on GotoBLAS (ILP64 version)")
+ (description
+ "OpenBLAS is a BLAS library forked from the GotoBLAS2-1.13 BSD version.
(ILP64 version)")
+ (license license:bsd-3)))
+
+
(define* (make-blis implementation #:optional substitutable?)
"Return a BLIS package with the given IMPLEMENTATION (see config/ in the
source tree for a list of implementations.)
--
2.19.0
0001-openblas-ilp64-Add-support-for-the-ILP64-storage-mod.patch
Description: Text Data